Uploaded image for project: 'Qpid Proton'
  1. Qpid Proton
  2. PROTON-1177

[proton-j] Source and Target interfaces are incomplete and confusing

Agile BoardAttach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • proton-0.12.1
    • proton-j-future
    • proton-j

    Description

      The org.apache.qpid.proton.amqp.transport.Source and org.apache.qpid.proton.amqp.transport.Target interfaces are used on the Link interface setters/getters, however they container almost none of the methods needed to use the Source and Target. The impls have all the necessary methods, but folks would currently need to cast the values to them in order to use in almost any meaningful way, and they exist in a completely different package which makes them less than obvious. Finally, most of the interfaces for engine objects have a factory in their interface for creating them, the Source and Target ones do not, making their use less obvious again.

      Changing the existing interface/impl names/packages would break most existing uses, so we probably want to avoid that, but we should at least update the interfaces to contain the required methods, and perhaps add the equivalent factories to make their creation more obvious.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            robbie Robbie Gemmell
            robbie Robbie Gemmell

            Dates

              Created:
              Updated:

              Slack

                Issue deployment