Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-2793 Make Pig Work on Windows without Cygwin
  3. PIG-2801

grunt "sh" command should invoke the shell implicitly instead of calling exec directly with the command tokens

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.10.0
    • 0.11, 0.10.1, 0.12.0
    • None
    • None
    • Reviewed

    Description

      The "sh" command in grunt is very sensitive to the behavior of exec. It requires that you provide an executable filename as the first argument, and those are sort of up for interpretation from platform to platform. For this to easily handle batch scripts, built-in commands, and executables with one semantic, it should spin up an intermediate command-shell. This would translate "sh <command>" into "exec("sh" ["-c", <command>])". This helps to smooth out some of the operating system differences between Windows and Linux, and also improves usability of grunt as a whole.

      Attachments

        1. PIG-2801.trunk.0002.patch
          70 kB
          John Gordon
        2. PIG-2801.trunk.0001.patch
          4 kB
          John Gordon
        3. 0008-Updating-test-execution-invocation-model.patch
          70 kB
          John Gordon
        4. 0003-Grunt-Streaming-script-executor-changes.patch
          5 kB
          John Gordon

        Issue Links

          Activity

            People

              jgordon John Gordon
              jgordon John Gordon
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: