Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5981

Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics

    XMLWordPrintableJSON

Details

    Description

      We update wallClockTimeMS and resultSetTimeMS when we reach the last row in our ResultSet iterations (see this). However, this is also called inside PhoenixResultSet.close(), see this.

      The problem is, these calls in-turn add elapsedTime again (endQuery and stopResultsetWatch) and so these metrics get 2X the value they should. Ideally we should change the metrics only if the stopWatch was running before calling stopWatch.stop or else we will count it multiple times.

      Attachments

        1. PHOENIX-5981-4.x-v1.patch
          11 kB
          Chinmay Kulkarni
        2. PHOENIX-5981-4.x-v2.patch
          11 kB
          Chinmay Kulkarni
        3. PHOENIX-5981-4.x-v3.patch
          11 kB
          Chinmay Kulkarni
        4. PHOENIX-5981-4.x-v4.patch
          11 kB
          Chinmay Kulkarni
        5. PHOENIX-5981-master-v1.patch
          10 kB
          Chinmay Kulkarni

        Activity

          People

            ckulkarni Chinmay Kulkarni
            ckulkarni Chinmay Kulkarni
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m