Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-5219

Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and testRowLockDuringPreBatchMutateWhenIndexed failures on the master branch

    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.1.0
    • None
    • None

    Description

      These tests are failing because when we set the timestamp in Indexer.preBatchMutateWithExceptions we call KeyValueUtil.ensureKeyValues on the list of cells and then call KeyValue.getTimestampOffset

      Pre 2.0 the cells objects are NoTagsKeyValue (which extend KeyValue). In 2.0 they are NoTagsByteBufferKeyValue (which doesn't extend KeyValue) so KeyValueUtil.ensureKeyValues returns a new list of objects on which we set the timestamp.
      The fix us to use CellUtil.setTimestamp to the set the timestamp directly on the cell.

      Attachments

        1. PHOENIX-5219.patch
          3 kB
          Thomas D'Silva

        Issue Links

          Activity

            People

              tdsilva Thomas D'Silva
              tdsilva Thomas D'Silva
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: