Uploaded image for project: 'Parquet'
  1. Parquet
  2. PARQUET-1683

Remove unnecessary string converting in readFooter method

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      The method (String filePath = file.toString()) is always called even filePath is not used(it is only used when an exception is thrown which is rare).  This kind of string conversion should be avoided when it is not used in terms of memory & CPU efficiency. 

       

      https://github.com/apache/parquet-mr/pull/695

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shangx@uber.com Xinli Shang
            shangx@uber.com Xinli Shang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment