Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-620

Modify the row filter API to use BiFunction

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      The current API for row filtering has a couple of issues:

      • The filter function is passed a VectorizedRowBatch instead of a MutableFilterContext.
      • The filter needs to know the precise location for the fields it needs out of the schema.

      I'd like to propose changing it from:

      Consumer<VectorizedRowBatch>

      to

      BiFunction<ColumnVector[], MutableFilterContext, Boolean>

      That has the advantage that the data that the function should read is explicitly passed to it and we remove the dependence on VectorizedRowBatch.

      Attachments

        Issue Links

          Activity

            People

              omalley Owen O'Malley
              omalley Owen O'Malley
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: