Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-601

Add more debug info to error messages in the scanner

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • None

    Description

      There are some exceptions which would be easier to debug if we had more debug info at hand. For instance, one frequently encountered error when Impala has stale metadata of an ORC file is:

      Invalid ORC postscript length
      

      It'd be better to also print the postscript length we read and the file size, so users can know whether the file is corrupt (so need data regeneration) or the metadata is stale (so need refresh).

      Also, there are some cases where the same kind of exception results in different messages, eg. in the ColumnReader.cc Decimal64ColumnReader::readBuffer throws

      ParseError("bad read in DoubleColumnReader::next()");

      on failing to read from the stream while DoubleColumnReader::readByte throws

      ParseError("Read past end of stream in Decimal64ColumnReader " + valueStream->getName());

      It would be nice to unify these.

      Attachments

        Issue Links

          Activity

            People

              norbertluksa Norbert Luksa
              norbertluksa Norbert Luksa
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m