Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-309

WriterImpl.close() calls WriterCallback methods out of order

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      }}org.apache.orc.impl.WriterImpl}}

        @Override
        public void close() throws IOException {
          if (callback != null) {
            callback.preFooterWrite(callbackContext);
          }
          // remove us from the memory manager so that we don't get any callbacks
          memoryManager.removeWriter(path);
          // actually close the file
          flushStripe();
          lastFlushOffset = writeFooter();
          physicalWriter.close();
        }
       

      so this causes preFooterWrite() to be called before preStripeWrite() from flushStripe().

      HIVE-18817 is one place where this shows up

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ekoifman Eugene Koifman
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: