Uploaded image for project: 'ORC'
  1. ORC
  2. ORC-1365

[C++] Use BlockBuffer to replace DataBuffer of rawInputBuffer in the CompressionStream

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.1.0
    • C++
    • None

    Description

      Discussion from Github issue: https://github.com/apache/orc/issues/1240

      In short, CompressionStream has fixed its input buffer to compression block size (which is 1M by default). Check here for reference: https://github.com/apache/orc/blob/main/c%2B%2B/src/Compression.cc#L108 .

      The piece of code can be improved by replacing its type from DataBuffer by BlockBuffer. In this way, it is able to start with a small initial size and automatically grow as needed.

      Attachments

        Issue Links

          Activity

            People

              luffyZ Hao Zou
              wgtmac Gang Wu
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: