Uploaded image for project: 'Oozie'
  1. Oozie
  2. OOZIE-3589

Avoid calling copyActionData method multiple times in ReRunXCommand

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 5.3.0
    • core
    • None

    Description

      Code is here.

      I don't think you should use the copyActionData method in a for loop. Just call it externally.

      Fixed like:

      for (int i = 0; i < actions.size(); i++) {
                  // Skipping to delete the sub workflow when rerun failed node option has been provided. As same
                  // action will be used to rerun the job.
                  if (!nodesToSkip.contains(actions.get(i).getName()) &&
                          !(conf.getBoolean(OozieClient.RERUN_FAIL_NODES, false) &&
                          SubWorkflowActionExecutor.ACTION_TYPE.equals(actions.get(i).getType()))) {
                      deleteList.add(actions.get(i));
                      LOG.info("Deleting Action[{0}] for re-run", actions.get(i).getId());
                  }
              }
      copyActionData(newWfInstance, oldWfInstance);
      

      Attachments

        1. OOZIE-3589-V1.patch
          0.8 kB
          Junfan Zhang

        Activity

          People

            zuston Junfan Zhang
            zuston Junfan Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: