Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-8896

API withDomainOverrideIgnored doesn't match the implementation of BinaryUploadOptions

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 1.24.0
    • None
    • api
    • None

    Description

      the new API withDomainOverrideIgnored though, it's named as withDomainOverrideIgnored for both BinaryDownloadOptions and BinaryUploadOptions per documentation, but it's `withDomainOverrideIgnore` in the implementation of BinaryUploadOptions class, it missed a ending d in the method name for BinaryUploadOptions,

      The document is wrong ATM and the API name doesn't match with each other, making change over that or just leave with it and fix the document?
      https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryUploadOptions.java#L96 https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jackrabbit-api/src/main/java/org/apache/jackrabbit/api/binary/BinaryDownloadOptions.java#L325Doc:
      https://jackrabbit.apache.org/oak/docs/features/direct-binary-access.html

      Attachments

        Activity

          People

            Unassigned Unassigned
            francoiszhang Jun Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: