Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4528

diff calculation in DocumentNodeStore should try to re-use journal info on diff cache miss

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Currently, diff information is filled into caches actively (local commits pushed in local_diff, externally read changes pushed into memory_diff). At the time of event processing though, the entries could have already been evicted.
      In that case, we fall back to computing diff by comparing 2 node-states which becomes more and more expensive (and eventually fairly non-recoverable leading to OAK-2683).

      To improve the situation somewhat, we can probably try to consult journal entries to read a smaller-superset of changed paths before falling down to comparison.

      /cc Marcel Reutegger, Chetan Mehrotra, Christian Egli

      Attachments

        1. queue-oak-4715.png
          145 kB
          Marcel Reutegger
        2. queue.png
          97 kB
          Marcel Reutegger

        Issue Links

        breaks

        Improvement - An improvement or enhancement to an existing feature or task. OAK-6495 Fallback to classic diff when journal is broken

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed
        depends upon

        Bug - A problem which impairs or prevents the functions of the product. OAK-4552 Checkpoints.getOldestRevisionToKeep() returns newest valid revision

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed

        Improvement - An improvement or enhancement to an existing feature or task. OAK-4553 Retain journal entries for valid checkpoints

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed

        Improvement - An improvement or enhancement to an existing feature or task. OAK-4556 Track branch on newBranchCommit()

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed
        is related to

        Bug - A problem which impairs or prevents the functions of the product. OAK-4682 ConcurrentModificationException in JournalEntry.TreeNode

        • Major - Major loss of function.
        • Closed

        Bug - A problem which impairs or prevents the functions of the product. OAK-4937 JournalGC failing with RDB DocumentStore

        • Major - Major loss of function.
        • Closed

        Bug - A problem which impairs or prevents the functions of the product. OAK-5228 Incorrect minTimestamp in DocumentNodeStore.diffImpl()

        • Major - Major loss of function.
        • Closed

        Improvement - An improvement or enhancement to an existing feature or task. OAK-2836 Create diff cache entry for merged persisted branch

        • Major - Major loss of function.
        • Resolved

        Improvement - An improvement or enhancement to an existing feature or task. OAK-4715 Reduce DocumentStore reads for local changes

        • Minor - Minor loss of function, or other problem where easy workaround is present.
        • Closed
        relates to

        Improvement - An improvement or enhancement to an existing feature or task. OAK-2683 the "hitting the observation queue limit" problem

        • Major - Major loss of function.
        • Open

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mreutegg Marcel Reutegger
            catholicon Vikas Saurabh
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment