Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4365

Redundant Action Class Lookup in DefaultAuthorizableActionProvider

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.2, 1.6.0
    • core
    • None

    Description

      while running benchmarks for OAK-4119 on the lastest trunk version i noticed that the DefaultAuthorizableActionProvider always looks up the configured action classes despite the fact that the set is fix and known to the implementation.

      this only became apparent in the benchmarks due to the introduction of OAK-4003, which has not yet been introduced during the initial benchmark runs (both for 1.4 and 1.6-SNAPSHOT).

      anyway: this could be simplified a lot and while doing so, i noticed that the DefaultAuthorizableActionProvider doesn't come with dedicated unit tests.

      Attachments

        Issue Links

          Activity

            People

              angela Angela Schreiber
              angela Angela Schreiber
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: