Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-4266

NodeDocumentCache#get method should be synchronized

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.2, 1.6.0
    • documentmk
    • None

    Description

      The NodeDocumentCache#get(String key, Callable) method may modify the cache if there's no value for the given key. Therefore, it should be synchronized using NodeDocumentLocks, as all the methods modifying the cache are.

      Right now, the get() method is invoked in 3 different places within the Oak codebase. All of them are critical sections anyway, so this modification won't result in a performance decrease.

      Attachments

        Activity

          People

            tomek.rekawek Tomek Rękawek
            tomek.rekawek Tomek Rękawek
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: