Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-3439

MissingLastRevSeeker potential race condition acquiring the lock

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1.0.23, 1.2.8, 1.3.9
    • 1.2.11, 1.3.10, 1.4
    • core, rdbmk
    • None

    Description

                  // This approach has a race condition where two different cluster
            // nodes
            // can acquire the lock simultaneously.
            UpdateOp update = new UpdateOp(Integer.toString(clusterId), true);
            update.set(ClusterNodeInfo.REV_RECOVERY_LOCK, RecoverLockState.ACQUIRED.name());
            store.createOrUpdate(Collection.CLUSTER_NODES, update);
            return true;

      It would be good if could harden this, however it seems that the conditions in UpdateOp only work on revision properties. mreutegg WDYT?

      Attachments

        1. OAK-3439.diff
          4 kB
          Julian Reschke
        2. OAK-3439.diff
          7 kB
          Julian Reschke

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. OAK-3491 DocumentDiscoveryLiteServiceTest makes incorrect call to MissingLastRevRecovery

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. OAK-3489 DocumentStore: introduce a "NotEquals" condition

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. OAK-4131 LastRevisionRecoveryAgent may throw ClassCastException

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. OAK-4100 ClusterNodeInfo lease renewal: add logging

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. OAK-3435 LastRevRecoveryAgent/MissingLastRevSeeker improvements

          • Major - Major loss of function.
          • Closed

          Activity

            People

              reschke Julian Reschke
              reschke Julian Reschke
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: