Uploaded image for project: 'Jackrabbit Oak'
  1. Jackrabbit Oak
  2. OAK-10338

PipelinedMergeSortTaskTest is failing on Windows due to line end issues

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.54.0
    • oak-run
    • None

    Description

      I think that this might actually be a bug and not a broken test. The problem is that the method java.io.BufferedWrite.newLine() acts platform dependendly. It's used here:

      https://github.com/apache/jackrabbit-oak/blob/25c01b81768c77e558078a92a31309910902f3a0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java#L732C29-L732C29

      As a result, the sorted file will have platform dependend line endings, while the original file might not. I have no idea if that's a problem.

      thomasm, chetanm, nsantos, wdyt?

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. OAK-10294 Indexing job: add new Pipelined Strategy for dumping Mongo contents in preparation for reindexing

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #1018

          Activity

            People

              reschke Julian Reschke
              baedke Manfred Baedke
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: