Uploaded image for project: 'Apache Nemo'
  1. Apache Nemo
  2. NEMO-349

PlanRewriter Unit Tests

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None

    Description

      Test that the PlanRewriter correctly enforces run-time IRDAG optimizations in the runtime (annotation/reshaping by RunTimePasses) through appropriate rewrites of executing PhysicalPlans.

      Two possible options for the test code (I am more leaning towards the former at the moment):

      • Simulate the execution of PhysicalPlans (i.e., mocked Scheduler with simulated task events)
        • Pro: Simpler test code, smaller scope, a variety of simulations (fine-grained control) possible
        • Con: Does not test Executor code
      • Actually execute PhysicalPlans with Executors
        • Pro: (Almost) Fully tests the compiler backend and the runtime
        • Con: May result in bloated test code, less control in execution steps 

      The tests should include

      • Run-time utility IRVertex insertion/deletion
      • Run-time IRVertex/IREdge annotations
      • Modifications to each category of ready/running/finished IRVertex objects

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            johnyangk John Yang

            Dates

              Created:
              Updated:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment