Uploaded image for project: 'Maven Release Plugin'
  1. Maven Release Plugin
  2. MRELEASE-239

release:perform and release:prepare should accept multi-line goals/preparationGoals configurations

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0-beta-6
    • 2.3
    • prepare
    • None
    • Patch

    Description

      When I specify a list of goals in my POM that span multiple lines (see an example below), only those goals before the newline are executed when I run "mvn release:perform".

      I have only noticed this for release:perform, but given what the code looks like, I assume it's an issue for release:prepare too.

      This is a minor problem, but an irritating one, because release:peform claims to successfully complete without actually executing all specified goals.

      I attach a patch to ForkedMavenExecutor.java that splits the goals list on newlines and carriage returns, in addition to the comma and space split characters that were there already.

      Here's an example configuration that will trigger the problem:

      <plugin>
      <artifactId>maven-release-plugin</artifactId>
      <configuration>
      ...
      <goals>
      package group:first-goal group:second-goal group:third-goal
      site-deploy changes:announcement-generate changes:announcement-mail
      </goals>
      </configuration>
      </plugin>

      Attachments

        1. ForkedMavenExecutor.patch
          0.9 kB
          Steven Rowe

        Activity

          People

            rfscholte Robert Scholte
            sarowe Steven Rowe
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: