Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-9210

Mesos v1 scheduler library does not properly handle SUBSCRIBE retries

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Mesosphere Sprint 2018-29, Mesosphere RI-6 Sprint 2018-30, Mesosphere RI-6 Sprint 2018-31, Mesos Integration RI10 Sp 38
    • 3

    Description

      After the authentication related refactor done as part of https://reviews.apache.org/r/62594/, the state of the scheduler is checked in `send` (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L234)  but it is changed in `_send` (https://github.com/apache/mesos/blob/master/src/scheduler/scheduler.cpp#L234). As a result, we can have 2 SUBSCRIBE calls in flight at the same time on the same connection! This is not good and not spec compliant of a HTTP client that is expecting a streaming response.

      We need to fix the library to either drop the retried SUBSCRIBE call if one is in progress (as it was before the refactor) or close the old connection and start a new connection to send the retried SUBSCRIBE call.

       

       

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tillt Till Toenshoff
            vinodkone Vinod Kone
            Alex R Alex R
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Agile

                Completed Sprints:
                Mesosphere Sprint 2018-29 ended 27/Sep/18
                Mesosphere RI-6 Sprint 2018-30 ended 15/Oct/18
                Mesosphere RI-6 Sprint 2018-31 ended 25/Oct/18
                Mesos Integration RI10 Sp 38 ended 30/Jan/19
                View on Board

                Slack

                  Issue deployment