Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7643

The order of isolators provided in '--isolation' flag is not preserved and instead sorted alphabetically

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.2, 1.2.0, 1.3.0
    • 1.6.0
    • containerization

    Description

      According to documentation and comments in code the order of the entries in the --isolation flag should specify the ordering of the isolators. Specifically, the `create` and `prepare` calls for each isolator should run serially in the order in which they appear in the --isolation flag, while the `cleanup` call should be serialized in reverse order (with exception of filesystem isolator which is always first).
      But in fact, the isolators provided in '--isolation' flag are sorted alphabetically.
      That happens in this line of code. In this line use of 'set<string>' is done (apparently instead of list or vector) and set is a sorted container.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MESOS-8818 VolumeSandboxPathIsolatorTest.SharedParentTypeVolume fails on macOS

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. MESOS-7909 Ordering dependency between 'linux/capabilities' and 'docker/runtime' isolator.

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. MESOS-5581 Guarantee ordering between Isolators

          • Major - Major loss of function.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. MESOS-8083 Mesos containerizer should run isolate() sequentially.

          • Major - Major loss of function.
          • Open

          Activity

            People

              jamespeach James Peach
              cherny Michael Cherny
              Gilbert Song Gilbert Song
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: