Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-7304

Fetcher should not depend on SlaveID.

    XMLWordPrintableJSON

Details

    • Mesosphere Sprint 55, Mesosphere Sprint 56, Mesosphere Sprint 57
    • 3

    Description

      Currently, various Fetcher interfaces depends on SlaveID, which is an unnecessary coupling. For instance:

      Try<Nothing> Fetcher::recover(const SlaveID& slaveId, const Flags& flags);
      
      Future<Nothing> Fetcher::fetch(
          const ContainerID& containerId,
          const CommandInfo& commandInfo,
          const string& sandboxDirectory,
          const Option<string>& user,
          const SlaveID& slaveId,
          const Flags& flags);
      

      Looks like the only reason we need a SlaveID is because we need to calculate the fetcher cache directory based on that. We should calculate the fetcher cache directory in the caller and pass that directory to Fetcher.

      Attachments

        Activity

          People

            kaysoky Joseph Wu
            jieyu Jie Yu
            Jie Yu Jie Yu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: