Uploaded image for project: 'Mesos'
  1. Mesos
  2. MESOS-6632

ContainerLogger might leak FD if container launch fails.

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Duplicate
    • 0.28.2, 1.0.1, 1.1.0
    • None
    • containerization
    • None

    Description

      In MesosContainerizer, if logger->prepare() succeeds but its continuation fails, the pipe fd allocated in the logger will get leaked. We cannot add a destructor in ContainerLogger::SubprocessInfo to close the fd because subprocess might close the OWNED fd.

      A FD abstraction might help here. In other words, subprocess will no longer be responsible for closing external FDs, instead, the FD destructor will be doing so.

      Attachments

        Issue Links

          Activity

            People

              abudnik Andrei Budnik
              jieyu Jie Yu
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: