FrameworkInfo should only be updated if the re-registration is valid

See Ben Mahler's comment in https://reviews.apache.org/r/32961/
FrameworkInfo should not be updated if the re-registration is invalid. This can happen in a few cases under the branching logic, so this requires some refactoring.
Notice that a

FrameworkErrorMessage

can be generated both inside

else if (from != framework->pid)

as well as from inside

failoverFramework(framework, from);