Uploaded image for project: 'Libcloud'
  1. Libcloud
  2. LIBCLOUD-247

dns drivers - update_record

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • None
    • Core

    Description

      I know its an edge case but say when we do update_record() and change the 'type' for the record
      and if it 'is' RecordType.A then the value for it is 0 and in all the dns drivers I see things like 'if type:' which will never be True isn't it ?

      and just fft isn't it a good practice not using keywords like 'type' . Guess we could've used something like record_type or zone_type ? or simply like pep says use 'single_trailing_underscore_:' http://www.python.org/dev/peps/pep-0008/

      I guess we need to set those record type constants starting from 1 in RecordType class.

      Attachments

        Activity

          People

            kami Tomaz Muraus
            dineshbhoopathy Dinesh Bhoopathy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: