Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-3566

Incorrect semantics for Prometheus-style histogram metrics

    XMLWordPrintableJSON

Details

    Description

      Original KUDU-3375 implementation incorrectly exposes summary-type Prometheus metrics as histogram-type ones for data collected by corresponding HDR histograms. For example, below are snippets from /metric and /metrics_prometheus for statistics on ListMasters RPC.

      The data exposed as Prometheus-style histogram metrics should have been reported as summary metrics instead.

      JSON-style:

      {   
          "name": "handler_latency_kudu_master_MasterService_ListMasters",                "total_count": 26,
          "min": 152,
          "mean": 301.2692307692308,
          "percentile_75": 324,
          "percentile_95": 468,
          "percentile_99": 844,
          "percentile_99_9": 844,
          "percentile_99_99": 844,
          "max": 844,
          "total_sum": 7833
      }
      

      Prometheus-style counterpart:

      # HELP kudu_master_handler_latency_kudu_master_MasterService_ListMasters Microseconds spent handling kudu.master.MasterService.ListMasters RPC requests
      # TYPE kudu_master_handler_latency_kudu_master_MasterService_ListMasters histogram
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_bucket{unit_type="microseconds", le="0.75"} 324
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_bucket{unit_type="microseconds", le="0.95"} 468
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_bucket{unit_type="microseconds", le="0.99"} 844
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_bucket{unit_type="microseconds", le="0.999"} 844
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_bucket{unit_type="microseconds", le="0.9999"} 844
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_bucket{unit_type="microseconds", le="+Inf"} 26
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_sum{unit_type="microseconds"} 7833
      kudu_master_handler_latency_kudu_master_MasterService_ListMasters_count{unit_type="microseconds"} 26
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              aserbin Alexey Serbin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: