Uploaded image for project: 'Kudu'
  1. Kudu
  2. KUDU-3421

Make command line error message more useful

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.17.0
    • CLI

    Description

      If the user runs this command for example:

      /data/9/abakai/kudu/build/debug% /data/9/abakai/kudu/build/debug/bin/kudu-tserver --fs_data_dirs=/data/9/abakai/kudu/build/debug/tserver-2/data --fs_wal_dir=/data/9/abakai/kudu/build/debug/tserver-2/wal --log_dir=/data/9/abakai/kudu/build/debug/tserver-2/log --rpc_bind_addresses=127.0.0.1:19874 --time_source=system_unsync --unlock_unsafe_flags --webserver_interface=127.0.0.1 --webserver_port=19875 --tserver_master_addrs=127.0.0.1:18764 --webserver_doc_root=/data/9/abakai/kudu/build/debug/../../www --memory_limit_hard_bytes=72050161527 -block_manager log  

      it works fine. But if the user adds "-logtostderr true", it will throw an error:

      [abakai@va1022]/data/9/abakai/kudu/build/debug% /data/9/abakai/kudu/build/debug/bin/kudu-tserver --fs_data_dirs=/data/9/abakai/kudu/build/debug/tserver-2/data --fs_wal_dir=/data/9/abakai/kudu/build/debug/tserver-2/wal --log_dir=/data/9/abakai/kudu/build/debug/tserver-2/log --rpc_bind_addresses=127.0.0.1:19874 --time_source=system_unsync --unlock_unsafe_flags --webserver_interface=127.0.0.1 --webserver_port=19875 --tserver_master_addrs=127.0.0.1:18764 --webserver_doc_root=/data/9/abakai/kudu/build/debug/../../www --memory_limit_hard_bytes=72050161527 -block_manager log -logtostderr true
      usage: /data/9/abakai/kudu/build/debug/bin/kudu-tserver 

      Which doesn't really help to identify which command line option is incorrect (and maybe how is it incorrect)
      (By the way the problem with the second command is that logtostderr doesn't need true or false option, it's existence indicates that logtostderr should be switched to true)

      Attachments

        Activity

          People

            Unassigned Unassigned
            abakai Bakai Ádám
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: