Uploaded image for project: 'Apache Knox'
  1. Apache Knox
  2. KNOX-1881

DefaultKeystoreService should use Java NIO API locking as well

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • None
    • 1.3.0
    • KnoxCLI, Server
    • None

    Description

      The file locking mechanism in org.apache.knox.gateway.services.security.impl.DefaultKeystoreService today relies on read/write locks to prevent multiple threads from editing a single keystore. Java NIO API file locking adds the protection for reading/writing from multiple JVMs. Since DefaultKeystoreService is used in both gateway and knoxcli, we need to protect against this type of access happening at once.

      https://docs.oracle.com/javase/8/docs/api/java/nio/channels/FileLock.html

      Attachments

        Issue Links

          is a clone of

          Improvement - An improvement or enhancement to an existing feature or task. KNOX-1821 Change file locking mechanism in DefaultKeystoreService to use Java NIO API

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. KNOX-2200 DefaultKeystoreService can lose entries under concurrent access

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. KNOX-1917 DefaultKeystoreService should use a shared read lock

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. KNOX-1230 Many Concurrent Requests to Knox causes URL Mangling

          • Major - Major loss of function.
          • Closed
          links to

          Web Link GitHub Pull Request #104

          Web Link PR #104

          Activity

            People

              krisden Kevin Risden
              rlevas Robert Levas
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m