[KAFKA-5972] Flatten SMT does not work with null values - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 0.11.0.0, 0.11.0.1
Fix Version/s: 1.0.3, 1.1.2, 2.0.2, 2.1.2, 2.2.2, 2.4.0, 2.3.1
Component/s: connect
Labels:
- easyfix
- patch

Flags:

Patch

Description

Hi,

I noticed a bug in Flatten SMT while doing tests with different SMTs that are provided out-of-box.

Flatten SMT does not work as expected with schemaless JSON that has properties with null values.

Example json:

  {A={D=dValue, B=null, C=cValue}}

The issue is in if statement that checks for null value.
Current version:

  for (Map.Entry<String, Object> entry : originalRecord.entrySet()) {
            final String fieldName = fieldName(fieldNamePrefix, entry.getKey());
            Object value = entry.getValue();
            if (value == null) {
                newRecord.put(fieldName(fieldNamePrefix, entry.getKey()), null);
                return;
            }
...

should be

  for (Map.Entry<String, Object> entry : originalRecord.entrySet()) {
            final String fieldName = fieldName(fieldNamePrefix, entry.getKey());
            Object value = entry.getValue();
            if (value == null) {
                newRecord.put(fieldName(fieldNamePrefix, entry.getKey()), null);
                continue;
            }

I have attached a patch containing the fix for this issue.