Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-6974

Static and shared compilation don't have compatible ccache entries

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 2.13.0
    • Impala 2.13.0
    • Backend
    • None

    Description

      In be/CMakeLists.txt, we add an -fPIC flag unconditionally:

      # allow linking of static libs into dynamic lib
      add_definitions(-fPIC)
      

      When building in static mode, every command will have an -fPIC flag. However, when building in shared mode, CMake adds -fPIC (or -fPIE) automatically, so every command will have -fPIC plus another -fPIC added by CMake. These extra flags prevent ccache from sharing entries between static and shared builds even after preprocessing.

       

      Attachments

        Activity

          People

            joemcdonnell Joe McDonnell
            joemcdonnell Joe McDonnell
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: