Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-4957

LLVM's failure should not trigger crash in Impalad

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • Impala 2.9.0
    • None
    • Backend

    Description

      There are various places in the LLVM code which can call report_fatal_error() when certain fatal error conditions are hit (e.g. failure to allocate memory). The call will trigger an exit() eventually. We should instead handle these failure cases gracefully and let the query carry on without codegen.

      https://github.com/llvm-mirror/llvm/blob/release_38/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp#L617

          Addr = IsCode ? MemMgr.allocateCodeSection(Allocate, Alignment, SectionID,
                                                     Name)
                        : MemMgr.allocateDataSection(Allocate, Alignment, SectionID,
                                                     Name, IsReadOnly);
          if (!Addr)
            report_fatal_error("Unable to allocate section memory!");
      

      Attachments

        Activity

          People

            kwho Michael Ho
            kwho Michael Ho
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: