Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-13016

Fix ambiguous row_regex that check for no-existence

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • Impala 4.4.0
    • Infrastructure
    • None

    Description

      There are few row_regex pattern used in EE test files that is ambiguous on whether a parttern not exist in all parts of results/runtime filter or at least one row does not have that pattern:

      $ git grep -n "row_regex: (?\!"
testdata/workloads/functional-query/queries/QueryTest/acid-clear-statsaccurate.test:34:row_regex: (?!.*COLUMN_STATS_ACCURATE)
testdata/workloads/functional-query/queries/QueryTest/acid-truncate.test:47:row_regex: (?!.*COLUMN_STATS_ACCURATE)
testdata/workloads/functional-query/queries/QueryTest/clear-statsaccurate.test:28:row_regex: (?!.*COLUMN_STATS_ACCURATE)
testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test:14:row_regex: (?!.*F03:JOIN BUILD.*)

      They should be replaced either with !row_regex or VERIFY_IS_NOT_IN comment.

      Attachments

        Activity

          People

            rizaon Riza Suminto
            rizaon Riza Suminto
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: