Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-12814

VERIFY_IS_NOT_IN does not work with row_regex:

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 4.3.0
    • Impala 4.4.0
    • Infrastructure
    • None
    • ghx-label-14

    Description

      When testing some changes that would add content to explain plan, I see that VERIFY_IS_NOT_IN does not work with row_regex. Here is a trivial case that should always fail:

      ---- RESULTS: VERIFY_IS_NOT_IN
      row_regex:.*

      It does not fail. It looks like it is doing set logic without paying attention to row_regex:

      def verify_query_result_is_not_in(expected_results, actual_results):
        assert_args_not_none(expected_results, actual_results)
        expected_set = set(map(unicode, expected_results.rows))
        actual_set = set(map(unicode, actual_results.rows))
        assert expected_set.isdisjoint(actual_set)

      https://github.com/apache/impala/blob/b15d6dc2e7df05392a1daa4bc1b3da9ca31a583b/tests/common/test_result_verifier.py#L298-L302

      It looks like some existing test cases use it this way.

      Attachments

        Activity

          People

            joemcdonnell Joe McDonnell
            joemcdonnell Joe McDonnell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: