Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
Impala 4.3.0
-
None
-
None
-
ghx-label-7
Description
When we start Thrift with SSL, we print a message indicating that the ssl_private_key_password_cmd succeeded:
if (!pem_password_cmd.empty()) {
if (!RunShellProcess(pem_password_cmd, &key_password_, true, {"JAVA_TOOL_OPTIONS"})) {
return Status(TErrorCode::SSL_PASSWORD_CMD_FAILED, pem_password_cmd, key_password_);
} else {
LOG(INFO) << "Command '" << pem_password_cmd << "' executed successfully, "
<< ".PEM password retrieved";
}
}
We don't print a message for the webserver's webserver_private_key_password_cmd:
const string& password_cmd = FLAGS_webserver_private_key_password_cmd;
if (!password_cmd.empty()) {
if (!RunShellProcess(password_cmd, &key_password, true, {"JAVA_TOOL_OPTIONS"})) {
return Status(TErrorCode::SSL_PASSWORD_CMD_FAILED, password_cmd, key_password);
}
options.push_back("ssl_private_key_password");
options.push_back(key_password.c_str());
}
We should print a message indicating that the command succeeded.