Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-12730

Avoid Weverything for Clang Tidy

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 4.4.0
    • Impala 4.4.0
    • Infrastructure
    • None
    • ghx-label-11

    Description

      When building Impala for Clang Tidy, we turn on -Weverything

      SET(CXX_FLAGS_TIDY "${CXX_FLAGS_TIDY} -Wall -W -Weverything -Wno-c++98-compat -Wno-padded")

      Clang Tidy uses these warnings to implement the "clang-diagnostic" Clang Tidy issues. The other Clang Tidy checkers don't need Weverything to function. Since we now use -Werror for our Clang builds, I think anything we would want to find with this could also be found by adding extra warnings to the regular Clang build.

      Weverything is super verbose and makes build failures much harder to find in the logs. It changes across Clang versions. In general, I think it is not worth it anymore. We could remove it and clean up .clang-tidy.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            joemcdonnell Joe McDonnell
            joemcdonnell Joe McDonnell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment