Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
Impala 4.4.0
-
None
-
ghx-label-11
Description
When building Impala for Clang Tidy, we turn on -Weverything
SET(CXX_FLAGS_TIDY "${CXX_FLAGS_TIDY} -Wall -W -Weverything -Wno-c++98-compat -Wno-padded")
Clang Tidy uses these warnings to implement the "clang-diagnostic" Clang Tidy issues. The other Clang Tidy checkers don't need Weverything to function. Since we now use -Werror for our Clang builds, I think anything we would want to find with this could also be found by adding extra warnings to the regular Clang build.
Weverything is super verbose and makes build failures much harder to find in the logs. It changes across Clang versions. In general, I think it is not worth it anymore. We could remove it and clean up .clang-tidy.