Uploaded image for project: 'IMPALA'
  1. IMPALA
  2. IMPALA-10884

Improve pretty-printing of fragment instance name

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • Impala 4.0.0
    • Impala 4.0.1
    • Backend
    • None
    • ghx-label-5

    Description

      When using impala-profile-tool with extended verbosity, SummaryStatsCounter and TimeSeriesCounter coming from different instances are printed with prefix number like this:

       

      - MemoryUsage[0] (2s000ms): 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 57.26 MB, 62.01 MB, 63.80 MB, 63.80 MB, 63.80 MB, 63.78 MB, 63.08 MB, 61.77 MB, 60.47 MB, 60.44 MB, 60.62 MB, 61.08 MB, 61.32 MB, 61.21 MB, 61.32 MB, 61.28 MB, 61.45 MB, 61.35 MB, 61.30 MB, 61.32 MB, 61.43 MB, 61.28 MB, 61.56 MB, 61.49 MB, 61.47 MB, 61.50 MB, 61.47 MB, 61.64 MB, 61.49 MB, 61.54 MB, 61.42 MB, 61.47 MB, 61.51 MB
 - MemoryUsage[1] (2s000ms): 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 32.64 MB, 57.42 MB, 63.74 MB, 63.74 MB, 63.74 MB, 63.74 MB, 63.89 MB, 63.41 MB, 61.98 MB, 62.72 MB, 61.88 MB, 61.24 MB, 61.09 MB, 61.15 MB, 61.17 MB, 61.47 MB, 61.63 MB, 61.68 MB, 61.38 MB, 61.57 MB, 61.58 MB, 61.44 MB, 61.61 MB, 61.62 MB, 61.37 MB, 61.64 MB, 61.63 MB, 61.36 MB, 61.70 MB, 61.49 MB, 61.45 MB, 61.48 MB, 61.50 MB, 61.44 MB
 - MemoryUsage[3] (2s000ms): 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 24.64 MB, 39.72 MB, 45.50 MB, 49.18 MB, 52.27 MB, 52.27 MB, 51.80 MB, 49.63 MB, 49.91 MB, 48.78 MB, 48.87 MB, 48.72 MB, 49.47 MB, 49.40 MB, 49.01 MB, 61.53 MB, 61.35 MB, 61.29 MB, 61.27 MB, 61.43 MB, 61.58 MB, 61.59 MB, 61.58 MB, 61.54 MB, 61.58 MB, 61.40 MB, 61.44 MB, 61.47 MB, 61.50 MB, 61.53 MB, 61.62 MB, 61.15 MB, 61.63 MB, 61.62 MB
...

       

      The prefix number maps into fragment instance from where that counter is coming from. However, the fragment instance name is still printed in single long line without prefix number like this:

      Fragment F00 [228 instances]:
 Instances: Instance 204c719f48777536:b83eb0ed00000001 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000002 (host=ia0306.halxg.cloudera.com:27000), , Instance 204c719f48777536:b83eb0ed00000004 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000005 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000006 (host=ia0306.halxg.cloudera.com:27000), , , Instance 204c719f48777536:b83eb0ed00000009 (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000a (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000b (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000c (host=ia0306.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000d (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000e (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed0000000f (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000010 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000011 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000012 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000013 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000014 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000015 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000016 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000017 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000018 (host=ia0318.halxg.cloudera.com:27000), Instance 204c719f48777536:b83eb0ed00000019 (host=ia0322.halxg.cloudera.com:27000), , , , Instance 204c719f48777536:b83eb0ed0000001d (host=ia0322.halxg.cloudera.com:27000), , , , Instance 204c719f48777536:b83eb0ed00000021 (host=ia0322.halxg.cloudera.com:27000), , , , Instance 204c719f48777536:b83eb0ed00000025 (host=ia0317.halxg.cloudera.com:27000), , , , ...

      This makes it hard to match counters with their fragment instance. We should break thing long line into multiple line and add prefix number.

      Attachments

        Issue Links

          relates to

          Sub-task - The sub-task of the issue IMPALA-9846 Switch to aggregated runtime profile representation

          • Major - Major loss of function.
          • Open

          Activity

            People

              rizaon Riza Suminto
              rizaon Riza Suminto
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: