Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-22026

Fix incorrect retry logic in GridCacheIoManager send method

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 2.17
    • None

    Description

      GridCacheIoManager#send[1] and GridCacheIoManager#sendOrderedMessage[2] have incorrect retryCnt comparison in catch block and real retries count will be one less, than configured.

      Thus, if you set IgniteConfiguration#setNetworkSendRetryCount to 1 and IgniteCheckedException has been thrown during sending of message because of network timeout, error, etc., then no actual retries will happen and message will be lost.

      Reproducer: GridCacheIoManagerRetryTest.patch

      Links:

      1. https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1222
      2. https://github.com/apache/ignite/blob/6286f67735b2eb7312bc61d5e0549b22f424348f/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheIoManager.java#L1289

      Attachments

        Issue Links

          Activity

            People

              shishkovilja Ilya Shishkov
              shishkovilja Ilya Shishkov
              Maksim Timonin Maksim Timonin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1.5h
                  1.5h