Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.0.0-alpha-1
    • None
    • None

    Description

          // Since newly initialized empty table has 0 for the parameter.
          if (Long.parseLong(statsParams.get(StatsSetupConst.NUM_FILES)) == 0) {
            return true;
          }
      

      This doesn't look safe; # of files could be set to 0 by an invalid update, or potentially a parallel update that we cannot see (not sure if this is possible; there's some code in metastore that updates basic stats outside of the scope of the query).

      It would be better to remove this, and see if it breaks some tests. If we do need this, there should be a negative test at some point

      Attachments

        1. HIVE-20046.01.patch
          10.58 MB
          Sergey Shelukhin

        Activity

          People

            sershe Sergey Shelukhin
            sershe Sergey Shelukhin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: