Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-10249

ACID: show locks should show who the lock is waiting for

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 1.0.0
    • 1.3.0, 2.1.0
    • Transactions
    • None

    Description

      instead of just showing state WAITING, we should include what the lock is waiting for. It will make diagnostics easier.

      It would also be useful to add QueryPlan.getQueryId() so it's easy to see which query the lock belongs to.

      1. need to store this in HIVE_LOCKS (additional field); this has a perf hit to do another update on failed attempt and to clear filed on successful attempt. (Actually on success, we update anyway). How exactly would this be displayed? Each lock can block but we acquire all parts of external lock at once. Since we stop at first one that blocked, we’d only update that one…
      2. This needs a matching Thrift change to pass to client: ShowLocksResponse
      3. Perhaps we can start updating this info after lock was in W state for some time to reduce perf hit.
      4. This is mostly useful for “Why is my query stuck”

      Attachments

        1. HIVE-10249.3.patch
          12 kB
          Eugene Koifman
        2. HIVE-10249.2.patch
          11 kB
          Eugene Koifman
        3. HIVE-10249.patch
          11 kB
          Eugene Koifman

        Issue Links

          Activity

            People

              ekoifman Eugene Koifman
              ekoifman Eugene Koifman
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: