[HDFS-16458] [SPS]: Fix bug for unit test of reconfiguring SPS mode - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Sub-task
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 3.4.0
Fix Version/s: 3.4.0
Component/s: sps, test
Labels:
- pull-request-available

Target Version/s:

3.4.0
Hadoop Flags:

Reviewed

Description

TestNameNodeReconfigure#verifySPSEnabled was compared with itself(isSPSRunning) at assertEquals.

In addition, after an internal SPS has been removed, spsService daemon will not start within StoragePolicySatisfyManager. I think the relevant code can be removed to simplify the code.

IMO, after reconfig SPS mode, we just need to confirm whether the mode is correct and whether spsManager is NULL.

Attachments

Issue Links

links to

GitHub Pull Request #3998

GitHub Pull Request #4038

GitHub Pull Request #4041

Activity

People

Assignee:: Tao Li

Reporter:: Tao Li

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 18/Feb/22 08:43

Updated:: 12/Feb/24 06:35

Resolved:: 02/Mar/22 03:26

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: