Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12278

LeaseManager operations are inefficient in 2.8.

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Blocker
    • Resolution: Fixed
    • 2.8.0
    • 2.9.0, 3.0.0-beta1, 2.8.2
    • namenode
    • None

    Description

      After HDFS-6757, LeaseManager #removeLease became expensive.
      HDFS-6757 changed the sortedLeases object from TreeSet to PriorityQueue.
      Previously the remove(Object) operation from sortedLeases was O(log n) but after the change it became O( n) since it has to find the object first.
      Recently we had an incident in one of our production cluster just hours after we upgraded from 2.7 to 2.8
      The sortledLeases object had approximately 100,000 items within it.
      While removing the lease, it will acquire the LeaseManager lock and that will slow down the lookup of lease also.

      HDFS-6757 is a good improvement which replaced the path by inode id.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shahrs87 Rushabh Shah Assign to me
            shahrs87 Rushabh Shah
            Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment