[HBASE-9262] Make KeyValue.KEY_COMPARATOR default for HFile WriterFactory - ASF JIRA

XML

Word

Printable

JSON

Hadoop Flags:

Reviewed
Release Note:

Hide
Previously, when using a WriterFactory to create an HFile writer, the HFile Writer would default to using a raw byte array comparator instead of one that was aware of the a KV's Key structure. All actual instances of HFileWriter creation required the specification of a KEY_COMPARATOR. With this modification the KEY_COMPARATOR becomes the default, and we add a special comparator for unit tests that required the rare old default semantics.

Show
Previously, when using a WriterFactory to create an HFile writer, the HFile Writer would default to using a raw byte array comparator instead of one that was aware of the a KV's Key structure. All actual instances of HFileWriter creation required the specification of a KEY_COMPARATOR. With this modification the KEY_COMPARATOR becomes the default, and we add a special comparator for unit tests that required the rare old default semantics.

This takes completed work mentioned in ~~HBASE-9247~~ as a reasonably sized patch to build upon.

Fixed defaults in HFile.Writer factory to default to Key-format-aware comparator (KeyComparator, later converted to KVComparator) instead of a Key-format oblivious byte[] comparator. (Essentially all instances require specifying KEY_COMPARATOR – why not just make it the default).
- Found that TestSeekTo, TestReseekTo and a handful of others depend on a different comparator because – ~~HBASE-7845~~ "breaks" assumptions in these tests.
Moved getComparator into TableName. (removed an instanceof bad smell)