Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-8597

compaction record (probably) can block WAL cleanup forever if region is closed without edits

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.95.0
    • 0.98.0, 0.95.1
    • None
    • None
    • Reviewed

    Description

      A region is opened by a server, major compaction is performed, that triggers a split, and the region is closed and split. There's no indication of memstore flush for this region.
      After that, LogRoller repeatedly tries to request the flush of this region due to large number of HLogs, but fails to flush it for hours because the region is not in online regions.
      It seems that what's happening is that when we append entries to WAL we add the first entry after we flush/open some region to "earliest unflushed seqNums per region" map in FSHLog. However, compaction now adds compaction record to WAL, which also affects this map. If the compaction record is the first entry for this region to go into some WAL, and there are no writes to the region after that, there will be no memstore flush and the entry will never be removed.
      In fact "flushing" for compaction record doesn't make sense, there's no preservation of the record outside WAL; so, we probably should not add it to "latest unflushed" map.

      Attachments

        1. HBASE-8597-v0.patch
          14 kB
          Sergey Shelukhin
        2. HBASE-8597-v1.patch
          15 kB
          Sergey Shelukhin
        3. 8597-v2.patch
          15 kB
          Ted Yu

        Activity

          People

            sershe Sergey Shelukhin
            sershe Sergey Shelukhin
            Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: