Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-822

Update thrift README and HBase.thrift to use thrift 20080411

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.2.1, 0.18.0
    • None
    • None

    Description

      From hbase-dev list titled 'Thrift':

      Hey,
      When using thrift as per the README.txt in
      $HBASE_HOME/src/examples/thrift is outdated and uses deprecated
      arguments for thrift.  The command should be
      
      $thrift --gen cpp --gen java -gen rb \
          ../../../src/java/org/apache/hadoop/hbase/thrift/Hbase.thrift
      
      Also, the Hbase.thrift file is a little outdated.  It uses namespaces now.
      
      java_package org.apache.hadoop.hbase.thrift.generated
      cpp_namespace apache.hadoop.hbase.thrift
      ruby_namespace Apache.Hadoop.Hbase.Thrift
      
      Should be
      
      namespace java org.apache.hadoop.hbase.thrift.generated
      namespace cpp  apache.hadoop.hbase.thrift
      namespace rb Apache.Hadoop.Hbase.Thrift
      
      I have attached both patch files.
      
      Thanks,
      Michael
      
      
      
      
      34,36c34,36
      < java_package org.apache.hadoop.hbase.thrift.generated
      < cpp_namespace apache.hadoop.hbase.thrift
      < ruby_namespace Apache.Hadoop.Hbase.Thrift
      ---
      > > namespace java org.apache.hadoop.hbase.thrift.generated
      > > namespace cpp  apache.hadoop.hbase.thrift
      > > namespace rb Apache.Hadoop.Hbase.Thrift
      
      
      
      12c12
      < thrift -cpp -java -rb \
      ---
      > > thrift --gen cpp -- gen java --gen rb \
      

      Attachments

        1. HBase.thrift.patch
          0.3 kB
          Michael Stack
        2. README.txt.patch
          0.1 kB
          Michael Stack

        Issue Links

          Activity

            People

              Unassigned Unassigned
              stack Michael Stack
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: