Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-7867

setPreallocSize is different with COMMENT in setupTestEnv in MiniZooKeeperCluster.java

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.94.6, 0.95.0
    • 0.94.6, 0.95.0
    • None
    • None
    • Reviewed

    Description

      setupTestEnv() just sets 100 bytes not 100k bytes

      private static void setupTestEnv() {
      // / XXX: From o.a.zk.t.ClientBaseprivate static void setupTestEnv() {
      // during the tests we run with 100K prealloc in the logs.
      // on windows systems prealloc of 64M was seen to take ~15seconds
      // resulting in test failure (client timeout on first session).
      // set env and directly in order to handle static init/gc issues
        System.setProperty("zookeeper.preAllocSize", "100");
        FileTxnLog.setPreallocSize(100);
      }
      

      to reduce too many call padLogFile(), I think 100k is correct.

      Attachments

        1. hbase-7867.patch
          0.8 kB
          DaeMyung Kang
        2. hbase-7867.patch
          0.9 kB
          DaeMyung Kang

        Activity

          People

            charsyam DaeMyung Kang
            charsyam DaeMyung Kang
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: