Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6878

DistributerLogSplit can fail to resubmit a task done if there is an exception during the log archiving

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Won't Fix
    • None
    • None
    • master
    • None

    Description

      The code in SplitLogManager# getDataSetWatchSuccess is:

      if (slt.isDone()) {
      LOG.info("task " + path + " entered state: " + slt.toString());
      if (taskFinisher != null && !ZKSplitLog.isRescanNode(watcher, path)) {
        if (taskFinisher.finish(slt.getServerName(), ZKSplitLog.getFileName(path)) == Status.DONE) {
          setDone(path, SUCCESS);
        } else {
          resubmitOrFail(path, CHECK);
        }
      } else {
        setDone(path, SUCCESS);
      }

      resubmitOrFail(path, CHECK);

      should be
      resubmitOrFail(path, FORCE);

      Without it, the task won't be resubmitted if the delay is not reached, and the task will be marked as failed.

      Attachments

        Issue Links

          is required by

          Umbrella - An overarching type made of sub-tasks HBASE-5843 Improve HBase MTTR - Mean Time To Recover

          • Major - Major loss of function.
          • Closed

          Activity

            People

              Unassigned Unassigned
              nkeywal Nicolas Liochon
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: