Details
Description
Found this when implementing HBASE-25051.
Basically there are 2 problems:
- IPCUtil.isFatalConnectionException only checks whether class name matches, so if we use a sub class for FatalConnectionException, it will return false which makes the logic incorrect.
- In BlockingRpcConnection, we will first check whether there is a call with the id but since we will pass -1 as call id for bad preamble header, we will return earlier without actually checking the error response.
This will not introduce big trouble in production as the call will still fail with connection closed exception, but still worth to fix, anyway.
Attachments
Issue Links
- blocks
-
HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry
- Resolved
- links to