Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-28312

The bad auth exception can not be passed to client rpc calls properly

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      Found this when implementing HBASE-25051.

      Basically there are 2 problems:

      1. IPCUtil.isFatalConnectionException only checks whether class name matches, so if we use a sub class for FatalConnectionException, it will return false which makes the logic incorrect.
      2. In BlockingRpcConnection, we will first check whether there is a call with the id but since we will pass -1 as call id for bad preamble header, we will return earlier without actually checking the error response.

      This will not introduce big trouble in production as the call will still fail with connection closed exception, but still worth to fix, anyway.

      Attachments

        Issue Links

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: