Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-28212

Do not need to maintain rollback step when root procedure does not support rollback

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      In HBASE-28210, we need to synchronized on RootProcedureState when updating procedure store, which will decrease the performance a lot when there are lots of sub procedures for a procedure, such as SCP, so it will impact MTTR.
      But actually, SCP does not support rollback, so I do not think we need to maintain this information. If so, I think we do not need the synchronization added in HBASE-28210, at least for SCP then. This could get the performance back.

      Attachments

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. HBASE-28248 Race between RegionRemoteProcedureBase and rollback operation could lead to ROLLEDBACK state be persisent to procedure store

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-28210 There could be holes in stack ids when loading procedures

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          links to

          Web Link GitHub Pull Request #5538

          Web Link GitHub Pull Request #5547

          Web Link GitHub Pull Request #5555

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: