Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
None
-
None
-
None
Description
During PR discussion on HBASE-28065 we observe that the value of onDiskSizeWithoutHeader is read and used before its portion of an HFile has had its checksum validated. A method parameter is also provided which is used when the caller knows what size to expect based on some other source. While there are guards in place that limit the range of values this field can take, that range remains large, something like [33,Integer.MAX_VALUE). We propose further limiting the range of this value to safeguard the region server from an excessively large allocation.
Conversation is in https://github.com/apache/hbase/pull/5384/files#r1322947549