Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-27785

Encapsulate and centralize totalBufferUsed in ReplicationSourceManager

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0-alpha-3
    • 2.6.0, 3.0.0-alpha-4
    • Replication
    • None

    Description

      ReplicationSourceManager.totalBufferUsed is a counter, and is scoped to ReplicationSourceManager, but it is copied to ReplicationSource and ReplicationSourceWALReader, which makes the logic about ReplicationSourceManager.totalBufferUsed is scattered throughout ReplicationSourceManager,ReplicationSource,ReplicationSourceWALReader and ReplicationSourceShipper. It causes duplicated code and would make tracing the buffer usage somewhat difficult when there is problem about totalBufferUsed. I think we should encapsulate and centralize it in ReplicationSourceManager.

      Attachments

        Activity

          People

            comnetwork chenglei
            comnetwork chenglei
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: