Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-27780

FileChangeWatcher improvements

VotersStop watchingWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.6.0, 3.0.0-alpha-4
    • None
    • None

    Description

      HBASE-27347 ported FileChangeWatcher from ZK so that we can reload certificates when the keystore/truststore files change. I'd like to make a few improvements:

      1. Add more context to the thread name, so that we can disambiguate when multiple are launched for different cluster connections or paths
      2. We currently launch a separate FileChangeWatcher for each of keystorePath and truststorePath, but in many cases they may be the same path. The runnable which gets called is identical for these, so this just results in extra work for no reason. We should check the configured paths and only launch one FileChangeWatcher if the two paths are identical.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bbeaudreault Bryan Beaudreault
            bbeaudreault Bryan Beaudreault
            Votes:
            0 Vote for this issue
            Watchers:
            2 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment